Bug 202493

Summary: FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Keith Miller
Reported 2019-10-02 14:04:47 PDT
FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes
Attachments
Patch (3.04 KB, patch)
2019-10-02 14:07 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2019-10-02 14:08 PDT, Keith Miller 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-10-02 14:07:16 PDT
Created attachment 380057 [details] Patch
Keith Miller
Comment 2 2019-10-02 14:08:12 PDT
Created attachment 380058 [details] Patch
Saam Barati
Comment 3 2019-10-02 14:12:10 PDT
Comment on attachment 380058 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380058&action=review > Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:256 > + if (instruction->opcodeID() == op_get_by_id) { do you want to do the is<OpGetById> instead?
Keith Miller
Comment 4 2019-10-02 14:18:50 PDT
Comment on attachment 380058 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380058&action=review >> Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:256 >> + if (instruction->opcodeID() == op_get_by_id) { > > do you want to do the is<OpGetById> instead? Sure, why not.
Keith Miller
Comment 5 2019-10-02 14:19:42 PDT
Committed r250629: <https://trac.webkit.org/changeset/250629>
Radar WebKit Bug Importer
Comment 6 2019-10-02 14:20:18 PDT
<rdar://problem/55924336>
Radar WebKit Bug Importer
Comment 7 2019-10-02 14:20:19 PDT
<rdar://problem/55924337>
Note You need to log in before you can comment on or make changes to this bug.