Bug 202466

Summary: Python 3: Add support in webkitpy.common.net.buildbot
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, ews-watchlist, glenn, jbedard, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202464
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2019-10-02 08:40:27 PDT
Add webkitpy.common.net.buildbot to test-webkitpy-python3
Attachments
Patch (7.45 KB, patch)
2019-10-15 14:49 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-10-15 14:49:58 PDT
Created attachment 381023 [details] Patch
Stephanie Lewis
Comment 2 2019-10-17 14:01:57 PDT
Comment on attachment 381023 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381023&action=review > Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:338 > + rendered = decode_for(cell.renderContents(), str) why is this different
Jonathan Bedard
Comment 3 2019-10-17 14:07:54 PDT
Comment on attachment 381023 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381023&action=review >> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:338 >> + rendered = decode_for(cell.renderContents(), str) > > why is this different For some reason, BeautifulSoup and bs4 render cells differently. In fairness, the new way of rendering things is more correct, but that's basically the difference. The decode_for call is important because in Python3, renderContents() returns raw bytes, we need string (aka, unicode in Python 3)
Stephanie Lewis
Comment 4 2019-10-17 14:21:09 PDT
maybe add a comment about beautiful soup then.
Jonathan Bedard
Comment 5 2019-10-17 14:39:29 PDT
Committed r251259: <https://trac.webkit.org/changeset/251259>
Radar WebKit Bug Importer
Comment 6 2019-10-17 14:40:17 PDT
<rdar://problem/56386174>
Note You need to log in before you can comment on or make changes to this bug.