Summary: | Implement RenderTheme::systemColor() for Windows | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Roman <eroman> | ||||||
Component: | Platform | Assignee: | Eric Roman <eroman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Eric Roman
2008-07-31 15:41:17 PDT
Created attachment 22590 [details]
Call through to GetSysColor() for RenderThemeSafari::systemColor()
-I think I need to do a parallel change to RenderThemeWin.cpp, but not sure.
-Not sure what sort of test to write for this, since the expected value will depend on the theme.
Comment on attachment 22590 [details]
Call through to GetSysColor() for RenderThemeSafari::systemColor()
Looks OK. The switch style is probably wrong by WebKit standards. I'd almost consider using a HashMap here, except that'd be a bunch of memory on the heap for no real need.
I wonder if we need any kind of caching here? Color does some amount of caching, but I don't think that applies here.
Adam Roben should comment.
Comment on attachment 22590 [details]
Call through to GetSysColor() for RenderThemeSafari::systemColor()
The point of RenderThemeSafari is to match the look of OS X and not the look of Windows.
RenderThemeWin (if someone used it) would be more suitable for this patch, since that theme is about matching the native Windows look. Created attachment 22611 [details]
I see. Moved the change from RenderThemeSafari to RenderThemeWin.
Comment on attachment 22611 [details]
I see. Moved the change from RenderThemeSafari to RenderThemeWin.
r=me
|