Summary: | WinLauncher does not start in WebKit-debug right out of the box. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stefan Landvogt <stefan.landvogt> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Attachments: |
|
Description
Stefan Landvogt
2008-07-31 14:24:17 PDT
Created attachment 22587 [details]
Just following arobens directions for fixing WinLauncher.
Comment on attachment 22587 [details] Just following arobens directions for fixing WinLauncher. Thanks for the patch! Two changes are needed before we can land this: 1. The change you made to the project file needs to be made for all configurations. You should choose "All Configurations" from the "Configuration" drop-down in the "Project Properties" dialog, then make the change. 2. You need to write a ChangeLog entry. See <http://webkit.org/coding/contributing.html> for instructions on how to do so. Created attachment 22588 [details]
Adding the changes to "All Configurations"
Created attachment 22589 [details]
Adding the properties to "all configurations" and add changelog entry
Comment on attachment 22589 [details] Adding the properties to "all configurations" and add changelog entry r=me Normally in ChangeLogs we mention the bug that's being fixed, like this: Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of the box <https://bugs.webkit.org/show_bug.cgi?id=20245> Reviewed by NOBODY (OOPS!) I can make this change before landing the patch. Thanks again! |