Bug 202407

Summary: [GTK][WPE] Stop using legacy custom protocol implementation
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, berto, bugs-noreply, ews-watchlist, gustavo, gyuyoung.kim, rakuco, ryuan.choi, sergio, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Fix WPE zan: review+

Carlos Garcia Campos
Reported 2019-10-01 08:43:30 PDT
Use the new approach, which is simpler and doesn't require to go to the network process to load custom protocols.
Attachments
Patch (67.82 KB, patch)
2019-10-01 08:48 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (63.78 KB, patch)
2019-10-01 09:05 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Fix WPE (63.99 KB, patch)
2019-10-01 09:14 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-10-01 08:48:31 PDT
Created attachment 379905 [details] Patch
EWS Watchlist
Comment 2 2019-10-01 08:49:07 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2019-10-01 08:57:52 PDT
Oops, I removed the wrong file :-P
Carlos Garcia Campos
Comment 4 2019-10-01 09:05:34 PDT
Created attachment 379908 [details] Patch
Carlos Garcia Campos
Comment 5 2019-10-01 09:14:42 PDT
Created attachment 379909 [details] Fix WPE
Carlos Garcia Campos
Comment 6 2019-10-01 09:33:00 PDT
The linking errors fixed here just by doing a clean build.
Carlos Garcia Campos
Comment 7 2019-10-02 01:00:39 PDT
Committed r250597: <https://trac.webkit.org/changeset/250597>
Note You need to log in before you can comment on or make changes to this bug.