Bug 202388

Summary: [FTW] Correct additional canvas test failures
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, don.olmstead, fujii.hironori, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brent Fulgham
Reported 2019-09-30 19:08:13 PDT
This patch cleans up a few errors in the Path and ImageData code causing some test failures.
Attachments
Patch (5.35 KB, patch)
2019-09-30 19:14 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2019-10-01 11:46 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2019-09-30 19:14:00 PDT
Created attachment 379871 [details] Patch
Fujii Hironori
Comment 2 2019-09-30 22:41:45 PDT
Comment on attachment 379871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379871&action=review > Source/WebCore/platform/graphics/win/Direct2DOperations.cpp:714 > + auto transformedRectToClear = transform.mapRect(rectToClear); mapRect returns a bounding rect if transform is rotated. Do you need to use fillPath? Path path; path.addRect(rect); fillPath(platformContext, path, Color::transparent);
Brent Fulgham
Comment 3 2019-10-01 11:40:33 PDT
Comment on attachment 379871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379871&action=review >> Source/WebCore/platform/graphics/win/Direct2DOperations.cpp:714 >> + auto transformedRectToClear = transform.mapRect(rectToClear); > > mapRect returns a bounding rect if transform is rotated. Do you need to use fillPath? > Path path; > path.addRect(rect); > fillPath(platformContext, path, Color::transparent); Oh! Good point. I'll simplify the high-level Path commands to the appropriate D2D set for this use case, and only do this when we are not translating. It seems like this path is only needed if the transform is not axis-aligned.
Brent Fulgham
Comment 4 2019-10-01 11:46:23 PDT
Created attachment 379920 [details] Patch
Brent Fulgham
Comment 5 2019-10-01 11:53:59 PDT
Before this change: 681 / 775 Pass After this change: 684 / 775 Pass
WebKit Commit Bot
Comment 6 2019-10-01 14:26:13 PDT
Comment on attachment 379920 [details] Patch Clearing flags on attachment: 379920 Committed r250581: <https://trac.webkit.org/changeset/250581>
WebKit Commit Bot
Comment 7 2019-10-01 14:26:15 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-10-01 14:27:17 PDT
<rdar://problem/55889950>
Note You need to log in before you can comment on or make changes to this bug.