| Summary: | Web Inspector: Debugger: don't allow blackboxing of scripts that aren't finished loading or failed to load | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Devin Rousso
2019-09-30 15:38:20 PDT
Created attachment 379847 [details]
Patch
Comment on attachment 379847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379847&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js:172 > + this.status = null; So `supportsScriptBlackboxing` can change from true to false? Comment on attachment 379847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379847&action=review >> Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js:172 >> + this.status = null; > > So `supportsScriptBlackboxing` can change from true to false? I don't think so, but it looks like it's possible for the finished "state" of a `WI.Resource` to be reverted due to some interleaving of Page and Network commands (`WI.Resource.prototype.revertMarkAsFinished`). Comment on attachment 379847 [details] Patch Clearing flags on attachment: 379847 Committed r250813: <https://trac.webkit.org/changeset/250813> All reviewed patches have been landed. Closing bug. |