Bug 202370

Summary: Allow pages using EventSource to enter the back/forward cache
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 202373    
Bug Blocks: 202293    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-09-30 13:47:29 PDT
Allow pages using EventSource to enter the back/forward cache.
Attachments
Patch (9.45 KB, patch)
2019-09-30 16:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.48 KB, patch)
2019-10-01 08:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.09 KB, patch)
2019-10-01 12:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.13 KB, patch)
2019-10-01 13:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.37 KB, patch)
2019-10-01 14:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.41 KB, patch)
2019-10-04 16:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-30 13:47:49 PDT
<rdar://problem/55853142>
Chris Dumez
Comment 2 2019-09-30 16:33:00 PDT
Created attachment 379853 [details] Patch
Chris Dumez
Comment 3 2019-10-01 08:46:47 PDT
Created attachment 379904 [details] Patch
Chris Dumez
Comment 4 2019-10-01 12:47:58 PDT
Created attachment 379931 [details] Patch
Chris Dumez
Comment 5 2019-10-01 13:02:25 PDT
Created attachment 379936 [details] Patch
Chris Dumez
Comment 6 2019-10-01 14:23:03 PDT
Created attachment 379950 [details] Patch
Chris Dumez
Comment 7 2019-10-03 14:04:08 PDT
Patch is ready for review.
Chris Dumez
Comment 8 2019-10-04 16:01:20 PDT
ping review?
Geoffrey Garen
Comment 9 2019-10-04 16:11:49 PDT
Comment on attachment 379950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379950&action=review r=me > Source/WebCore/page/EventSource.cpp:427 > + if (std::exchange(m_shouldDispatchErrorEventOnResume, false)) { > + scriptExecutionContext()->postTask([this, pendingActivity = makePendingActivity(*this)](ScriptExecutionContext&) { > + if (!isContextStopped()) > + dispatchErrorEvent(); > + }); Would it be crazy just to silently reconnect instead?
Chris Dumez
Comment 10 2019-10-04 16:15:23 PDT
Comment on attachment 379950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379950&action=review >> Source/WebCore/page/EventSource.cpp:427 >> + }); > > Would it be crazy just to silently reconnect instead? I can give it a shot. It would be nice.
Chris Dumez
Comment 11 2019-10-04 16:54:19 PDT
Created attachment 380268 [details] Patch
Chris Dumez
Comment 12 2019-10-04 16:55:10 PDT
Requesting review again since I changed the approach to reconnect the EventSource when restoring from page cache.
Geoffrey Garen
Comment 13 2019-10-04 17:09:56 PDT
Comment on attachment 380268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380268&action=review r=me > Source/WebCore/page/EventSource.cpp:429 > + scheduleReconnect(); Shiny! :P
WebKit Commit Bot
Comment 14 2019-10-04 18:38:28 PDT
Comment on attachment 380268 [details] Patch Clearing flags on attachment: 380268 Committed r250761: <https://trac.webkit.org/changeset/250761>
WebKit Commit Bot
Comment 15 2019-10-04 18:38:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.