Bug 202335

Summary: [Experiment][iOS] Add temporary HTTP header to distinguish iPads for requests to Google
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, commit-queue, dbates, ews-watchlist, ggaren, japhet, mjs, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 202367    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2019-09-27 15:36:55 PDT
Add temporary HTTP header to distinguish device types for requests to Google as an experiment.
Attachments
Patch (2.76 KB, patch)
2019-09-27 16:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.90 KB, patch)
2019-09-27 16:42 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-27 15:37:10 PDT
<rdar://problem/55790994>
Chris Dumez
Comment 2 2019-09-27 16:23:03 PDT
Created attachment 379772 [details] Patch
Chris Dumez
Comment 3 2019-09-27 16:42:21 PDT
Created attachment 379774 [details] Patch
Maciej Stachowiak
Comment 4 2019-09-28 12:35:02 PDT
Comment on attachment 379774 [details] Patch Code change looks good. Though there's still some debate over whether we should do this, I think it would be good to land and then discuss whether to change what we are doing, given the short timeline.
Chris Dumez
Comment 5 2019-09-28 14:32:57 PDT
Comment on attachment 379774 [details] Patch Thanks.
Chris Dumez
Comment 6 2019-09-28 14:38:18 PDT
Comment on attachment 379774 [details] Patch Clearing flags on attachment: 379774 Committed r250483: <https://trac.webkit.org/changeset/250483>
Chris Dumez
Comment 7 2019-09-28 14:38:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.