Bug 202330

Summary: [JSC] Keep JSString::value(ExecState*)'s result as String instead of `const String&`
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
saam: review+
Patch none

Yusuke Suzuki
Reported 2019-09-27 13:28:22 PDT
[JSC] Keep JSString::value(ExecState*)'s result as String instead of `const String&`
Attachments
Patch (11.59 KB, patch)
2019-09-27 14:01 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (12.03 KB, patch)
2019-09-27 14:04 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Patch (12.04 KB, patch)
2019-09-27 14:14 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-09-27 14:01:39 PDT
Created attachment 379762 [details] Patch
Yusuke Suzuki
Comment 2 2019-09-27 14:04:42 PDT
Created attachment 379763 [details] Patch
Mark Lam
Comment 3 2019-09-27 14:11:25 PDT
Comment on attachment 379763 [details] Patch r=me too if jsc tests pass with a debug build. The reason is because you added a new ThrowScope. Need to make sure that there are no new exception check validation failures.
Yusuke Suzuki
Comment 4 2019-09-27 14:14:20 PDT
Created attachment 379765 [details] Patch Patch for landing
Yusuke Suzuki
Comment 5 2019-09-27 14:15:05 PDT
(In reply to Mark Lam from comment #3) > Comment on attachment 379763 [details] > Patch > > r=me too if jsc tests pass with a debug build. The reason is because you > added a new ThrowScope. Need to make sure that there are no new exception > check validation failures. Thanks, I've just fixed and uploaded the patch for landing. I'll check EWS before landing it :)
Yusuke Suzuki
Comment 6 2019-09-27 14:15:36 PDT
<rdar://problem/55774964>
Yusuke Suzuki
Comment 7 2019-09-27 20:40:30 PDT
Committed r250479: <https://trac.webkit.org/changeset/250479>
Note You need to log in before you can comment on or make changes to this bug.