Bug 20231

Summary: accNavigate: no screen element found in the specified direction should return S_FALSE
Product: WebKit Reporter: Jonas Klink <klinktech>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jhoneycutt
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Fixes the issue described in this bug. jhoneycutt: review+

Jonas Klink
Reported 2008-07-30 10:51:45 PDT
In AccessibleBase::accNavigate, if childObj is null, we should return S_FALSE, not E_FAIL (see MSDN spec: http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx).
Attachments
Fixes the issue described in this bug. (927 bytes, patch)
2008-07-30 16:02 PDT, Jonas Klink 		jhoneycutt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonas Klink
Comment 1 2008-07-30 10:52:02 PDT
jklink: have a patch for this ready
Jonas Klink
Comment 2 2008-07-30 16:02:51 PDT
Created attachment 22567 [details] Fixes the issue described in this bug.
Eric Seidel (no email)
Comment 3 2008-08-01 15:47:50 PDT
Comment on attachment 22567 [details] Fixes the issue described in this bug. I assume Jon is the best person to review this.
Jon Honeycutt
Comment 4 2008-08-08 00:24:31 PDT
Comment on attachment 22567 [details] Fixes the issue described in this bug. The ChangeLog should include the URL of the bug and of the MSDN page. r=me, thanks, Jonas!
Mark Rowe (bdash)
Comment 5 2008-08-21 19:19:18 PDT
Jonas, every patch of yours that I've tried to apply has given me "Malformed patch" errors in the ChangeLog hunk. Can you please create patches using svn-create-patch in the future so that we don't have to jump through hoops and hand-edit your patches to apply them? Thanks!
Mark Rowe (bdash)
Comment 6 2008-08-21 19:20:42 PDT
Landed in r35887.
Note You need to log in before you can comment on or make changes to this bug.