Bug 20230

Summary: get_accState should be testing state on childObj
Product: WebKit Reporter: Jonas Klink <klinktech>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jhoneycutt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Fixes the issue described in this bug.
jhoneycutt: review+
Fixes the newlines and my name =) jhoneycutt: review+

Jonas Klink
Reported 2008-07-30 10:31:17 PDT
In AccessibleBase::get_accState, the large conditional should be testing childObj, and not m_object .
Attachments
Fixes the issue described in this bug. (2.76 KB, patch)
2008-07-30 11:17 PDT, Jonas Klink 		jhoneycutt: review+
DetailsFormatted DiffDiff
Fixes the newlines and my name =) (2.88 KB, patch)
2008-07-30 16:00 PDT, Jonas Klink 		jhoneycutt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonas Klink
Comment 1 2008-07-30 10:31:53 PDT
(jklink): I am working on a patch for this.
Jonas Klink
Comment 2 2008-07-30 11:17:49 PDT
Created attachment 22556 [details] Fixes the issue described in this bug.
Jon Honeycutt
Comment 3 2008-07-30 15:28:27 PDT
Comment on attachment 22556 [details] Fixes the issue described in this bug. +2008-07-30 klinktech@gmail.com Did you mean to leave out your name? + Changes get_accState to test state on childObj, instead of m_object (BUG: http://bugs.webkit.org/show_bug.cgi?id=20230). Also adds null init of output in get_accDefaultAction. Reviewed by NOBODY (OOPS!). Could you add some line breaks? r=me!
Jonas Klink
Comment 4 2008-07-30 16:00:03 PDT
Created attachment 22565 [details] Fixes the newlines and my name =)
Jon Honeycutt
Comment 5 2008-07-30 16:01:19 PDT
Comment on attachment 22565 [details] Fixes the newlines and my name =) Thanks!
Mark Rowe (bdash)
Comment 6 2008-08-21 19:20:30 PDT
Landed in r35886.
Note You need to log in before you can comment on or make changes to this bug.