Bug 20230 - get_accState should be testing state on childObj
Summary: get_accState should be testing state on childObj
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-30 10:31 PDT by Jonas Klink
Modified: 2008-08-21 19:20 PDT (History)
1 user (show)

See Also:

Attachments
Fixes the issue described in this bug. (2.76 KB, patch)
2008-07-30 11:17 PDT, Jonas Klink 		jhoneycutt: review+
Details | Formatted Diff | Diff
Fixes the newlines and my name =) (2.88 KB, patch)
2008-07-30 16:00 PDT, Jonas Klink 		jhoneycutt: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Klink 2008-07-30 10:31:17 PDT 
In AccessibleBase::get_accState, the large conditional should be testing childObj, and not m_object .
Comment 1 Jonas Klink 2008-07-30 10:31:53 PDT 
(jklink): I am working on a patch for this.
Comment 2 Jonas Klink 2008-07-30 11:17:49 PDT 
Created attachment 22556 [details]
Fixes the issue described in this bug.
Comment 3 Jon Honeycutt 2008-07-30 15:28:27 PDT 
Comment on attachment 22556 [details]
Fixes the issue described in this bug.

+2008-07-30 klinktech@gmail.com  

Did you mean to leave out your name?

+        Changes get_accState to test state on childObj, instead of m_object (BUG: http://bugs.webkit.org/show_bug.cgi?id=20230). Also adds null init of output in get_accDefaultAction. Reviewed by NOBODY (OOPS!).
Could you add some line breaks?

r=me!
Comment 4 Jonas Klink 2008-07-30 16:00:03 PDT 
Created attachment 22565 [details]
Fixes the newlines and my name =)
Comment 5 Jon Honeycutt 2008-07-30 16:01:19 PDT 
Comment on attachment 22565 [details]
Fixes the newlines and my name =)

Thanks!
Comment 6 Mark Rowe (bdash) 2008-08-21 19:20:30 PDT 
Landed in r35886.