Bug 202297

Summary: Add some logging to help diagnose blank or stuck WKWebViews
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, commit-queue, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2019-09-26 16:28:37 PDT
Add some logging to help diagnose blank or stuck WKWebViews
Attachments
Patch (18.73 KB, patch)
2019-09-26 16:34 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (18.76 KB, patch)
2019-09-26 17:14 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-09-26 16:34:51 PDT
Created attachment 379694 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-09-26 16:35:35 PDT
<rdar://problem/55763610>
Wenson Hsieh
Comment 3 2019-09-26 17:07:13 PDT
Comment on attachment 379694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379694&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:379 > + WTF::Optional<MonotonicTime> _timeOfFirstVisibleContentRectUpdateWithPendingCommit; Nit - I don’t think the WTF:: is necessary here.
Tim Horton
Comment 4 2019-09-26 17:14:52 PDT
Created attachment 379700 [details] Patch
Tim Horton
Comment 5 2019-09-26 17:15:16 PDT
You are correct though this file is full of it. I removed it in my case but not the others.
WebKit Commit Bot
Comment 6 2019-09-26 17:59:43 PDT
Comment on attachment 379700 [details] Patch Clearing flags on attachment: 379700 Committed r250405: <https://trac.webkit.org/changeset/250405>
WebKit Commit Bot
Comment 7 2019-09-26 17:59:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.