Bug 202285

Summary:

Remove unused WebProcessPool::setCanHandleHTTPSServerTrustEvaluation

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	youennf: review+

Description Alex Christensen 2019-09-26 14:00:12 PDT

Remove unused WebProcessPool::setCanHandleHTTPSServerTrustEvaluation

Comment 1 Alex Christensen 2019-09-26 14:06:24 PDT

Created attachment 379678 [details]
Patch

Comment 2 Alex Christensen 2019-09-26 14:59:13 PDT

Created attachment 379684 [details]
Patch

Comment 3 youenn fablet 2019-09-26 23:14:21 PDT

Comment on attachment 379684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379684&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:580
> +            auto decisionHandler = makeBlockPtr([_session = makeWeakPtr(_session.get()), completionHandler = makeBlockPtr(completionHandler), taskIdentifier, networkDataTask = RefPtr<NetworkDataTaskCocoa>(networkDataTask)](NSURLAuthenticationChallenge *challenge, OSStatus trustResult) mutable {

makeRefPtr(networkDataTask)

Comment 4 Alex Christensen 2019-09-27 07:34:29 PDT

http://trac.webkit.org/r250422

Comment 5 Radar WebKit Bug Importer 2019-09-27 07:35:18 PDT

<rdar://problem/55781362>

Comment 6 Alex Christensen 2019-11-22 13:25:24 PST

Reverted in http://trac.webkit.org/r252796
Needs more investigation.

Comment 7 Alex Christensen 2019-11-22 17:13:34 PST

Relanded in http://trac.webkit.org/r252819