Bug 202270 – IDBRequest should not prevent a page from entering the back/forward cache

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Chris Dumez]

IDBRequest should not prevent a page from entering the back/forward cache. This sometimes prevents weather.com from entering the back/forward cache.

[Radar WebKit Bug Importer]

<rdar://problem/55744717>

[Chris Dumez]

Created attachment 379644 [details]
Patch

[youenn fablet]

Comment on attachment 379644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379644&action=review

> Source/WebCore/Modules/indexeddb/IDBRequest.cpp:265
> +    return true;

This change also affects IDBOpenDBRequest.
I think your reasoning for IDBRequest also applies to IDBOpenDBRequest (events are enqueued).
It might be good to double check this though.

[Chris Dumez]

Comment on attachment 379644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379644&action=review

>> Source/WebCore/Modules/indexeddb/IDBRequest.cpp:265
>> +    return true;
> 
> This change also affects IDBOpenDBRequest.
> I think your reasoning for IDBRequest also applies to IDBOpenDBRequest (events are enqueued).
> It might be good to double check this though.

Yes, I have checked that IDBOpenDBRequest properly queues its upgradeneeded / blocked events as well.

[Chris Dumez]

Comment on attachment 379644 [details]
Patch

Clearing flags on attachment: 379644

Committed r250425: <https://trac.webkit.org/changeset/250425>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.