Bug 202270 - IDBRequest should not prevent a page from entering the back/forward cache
Summary: IDBRequest should not prevent a page from entering the back/forward cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202291 202293
  Show dependency tree / graph
 
Reported: 2019-09-26 08:40 PDT by Chris Dumez
Modified: 2019-09-27 08:56 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.54 KB, patch)
2019-09-26 08:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-26 08:40:33 PDT 
IDBRequest should not prevent a page from entering the back/forward cache. This sometimes prevents weather.com from entering the back/forward cache.
Comment 1 Radar WebKit Bug Importer 2019-09-26 08:40:51 PDT 
<rdar://problem/55744717>
Comment 2 Chris Dumez 2019-09-26 08:47:31 PDT 
Created attachment 379644 [details]
Patch
Comment 3 youenn fablet 2019-09-27 07:48:52 PDT 
Comment on attachment 379644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379644&action=review

> Source/WebCore/Modules/indexeddb/IDBRequest.cpp:265
> +    return true;

This change also affects IDBOpenDBRequest.
I think your reasoning for IDBRequest also applies to IDBOpenDBRequest (events are enqueued).
It might be good to double check this though.
Comment 4 Chris Dumez 2019-09-27 08:20:26 PDT 
Comment on attachment 379644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379644&action=review

>> Source/WebCore/Modules/indexeddb/IDBRequest.cpp:265
>> +    return true;
> 
> This change also affects IDBOpenDBRequest.
> I think your reasoning for IDBRequest also applies to IDBOpenDBRequest (events are enqueued).
> It might be good to double check this though.

Yes, I have checked that IDBOpenDBRequest properly queues its upgradeneeded / blocked events as well.
Comment 5 Chris Dumez 2019-09-27 08:56:07 PDT 
Comment on attachment 379644 [details]
Patch

Clearing flags on attachment: 379644

Committed r250425: <https://trac.webkit.org/changeset/250425>
Comment 6 Chris Dumez 2019-09-27 08:56:09 PDT 
All reviewed patches have been landed.  Closing bug.