Summary: | [Cocoa] REGRESSION (r245672): Contenteditable with optical sizing freezes Safari | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | nilfgard | ||||||||||
Component: | CSS | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andrea, annulen, ap, ews-watchlist, gyuyoung.kim, mmaxfield, rakuco, ryuan.choi, sergio, thorton, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Other | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | macOS 10.14 | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=202198 | ||||||||||||
Attachments: |
|
Description
nilfgard
2019-09-26 02:40:58 PDT
*** This bug has been marked as a duplicate of bug 202198 *** The fix for the other bug doesn't fix this one. *** Bug 202556 has been marked as a duplicate of this bug. *** Created attachment 380179 [details]
Patch
There is some build breakage on EWS. *** Bug 202556 has been marked as a duplicate of this bug. *** Created attachment 380252 [details]
Patch
Created attachment 380256 [details]
Patch
fast/forms/contenteditable-font-optical-size.html is failing on iOS. Created attachment 380713 [details]
Patch
Comment on attachment 380713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380713&action=review > Source/WebKit/Shared/Cocoa/CoreTextHelpers.mm:2 > + * Copyright (C) 2017 Apple Inc. All rights reserved. -2019? > Source/WebKit/Shared/Cocoa/CoreTextHelpers.mm:52 > + END_BLOCK_OBJC_EXCEPTIONS I *think* this being post-return is OK, but I don't recall what it expands to Committed r251086: <https://trac.webkit.org/changeset/251086> |