Bug 202262

Summary: [Cocoa] REGRESSION (r245672): Contenteditable with optical sizing freezes Safari
Product: WebKit Reporter: nilfgard
Component: CSSAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: andrea, annulen, ap, ews-watchlist, gyuyoung.kim, mmaxfield, rakuco, ryuan.choi, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Mac   
OS: macOS 10.14   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202198
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch thorton: review+

nilfgard
Reported 2019-09-26 02:40:58 PDT
Hello. Contenteditable + text-rendering: optimizeLegibility + font-family: -apple-system crashes Safari 13 and 13.0.1. This codepen shows the problem: https://codepen.io/nilfgard/pen/GRKLgqr
Attachments
Patch (18.90 KB, patch)
2019-10-03 18:32 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (16.17 KB, patch)
2019-10-04 14:12 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (16.65 KB, patch)
2019-10-04 15:03 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (26.40 KB, patch)
2019-10-10 19:01 PDT, Myles C. Maxfield 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2019-09-29 15:22:05 PDT
*** This bug has been marked as a duplicate of bug 202198 ***
Myles C. Maxfield
Comment 2 2019-10-03 17:37:02 PDT
The fix for the other bug doesn't fix this one.
Myles C. Maxfield
Comment 3 2019-10-03 18:31:23 PDT
*** Bug 202556 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 4 2019-10-03 18:32:43 PDT
Created attachment 380179 [details] Patch
Radar WebKit Bug Importer
Comment 5 2019-10-03 18:33:08 PDT
<rdar://problem/55969922>
Alexey Proskuryakov
Comment 6 2019-10-03 19:37:24 PDT
There is some build breakage on EWS.
Myles C. Maxfield
Comment 7 2019-10-04 14:10:09 PDT
*** Bug 202556 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 8 2019-10-04 14:12:32 PDT
Created attachment 380252 [details] Patch
Myles C. Maxfield
Comment 9 2019-10-04 15:03:06 PDT
Created attachment 380256 [details] Patch
Alexey Proskuryakov
Comment 10 2019-10-04 18:24:28 PDT
fast/forms/contenteditable-font-optical-size.html is failing on iOS.
Myles C. Maxfield
Comment 11 2019-10-10 19:01:24 PDT
Created attachment 380713 [details] Patch
Tim Horton
Comment 12 2019-10-14 10:24:54 PDT
Comment on attachment 380713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=380713&action=review > Source/WebKit/Shared/Cocoa/CoreTextHelpers.mm:2 > + * Copyright (C) 2017 Apple Inc. All rights reserved. -2019? > Source/WebKit/Shared/Cocoa/CoreTextHelpers.mm:52 > + END_BLOCK_OBJC_EXCEPTIONS I *think* this being post-return is OK, but I don't recall what it expands to
Myles C. Maxfield
Comment 13 2019-10-14 12:43:09 PDT
Committed r251086: <https://trac.webkit.org/changeset/251086>
Note You need to log in before you can comment on or make changes to this bug.