Bug 20224

Summary:

Include the Writing Direction sub-menu in the context menu of the Qt port.

Product:

WebKit

Reporter:

Erik L. Bunce <elbunce>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

hausmann

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
Implements inclusion of the Writing Direction sub-menu.	hausmann: review-
Implements inclusion of the writing Direction sub-menu on all non-GTK platforms.	hausmann: review+

Erik L. Bunce

Reported 2008-07-29 22:09:03 PDT

Include the Writing Direction sub-menu in the context menu of the Qt port. This can be helpful in international contexts, also makes us more on par with the Mac port.

Attachments
Implements inclusion of the Writing Direction sub-menu. (1.56 KB, patch) 2008-07-29 22:11 PDT, Erik L. Bunce	hausmann: review-	Details Formatted Diff Diff
Implements inclusion of the writing Direction sub-menu on all non-GTK platforms. (1.59 KB, patch) 2008-07-31 08:15 PDT, Erik L. Bunce	hausmann: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Erik L. Bunce

Comment 1 2008-07-29 22:11:50 PDT

Created attachment 22550 [details] Implements inclusion of the Writing Direction sub-menu. Part of the great bug 20207 patch split...

Simon Hausmann

Comment 2 2008-07-31 06:14:07 PDT

Comment on attachment 22550 [details] Implements inclusion of the Writing Direction sub-menu. I agree with the patch in principle, but I think the #ifdefs are not entirely correct. Revision 34426 accidentially put the writing direction menu item into a PLATFORM(MAC) block where previously it was effectively !PLATFORM(GTK). Before the change it was available on all platforms (mac, win, wx, qt, etc.) except Gtk, now it's only available for the mac. Can you fix it that way around using !PLATFORM(GTK) and refer to change 34426 in the change log? Thanks :)

Erik L. Bunce

Comment 3 2008-07-31 08:15:41 PDT

Created attachment 22576 [details] Implements inclusion of the writing Direction sub-menu on all non-GTK platforms.

Simon Hausmann

Comment 4 2008-07-31 10:19:25 PDT

Comment on attachment 22576 [details] Implements inclusion of the writing Direction sub-menu on all non-GTK platforms. Thanks!

Simon Hausmann

Comment 5 2008-07-31 10:20:13 PDT

Landed in r35486

Note You need to log in before you can comment on or make changes to this bug.