Bug 202178

Summary: Move schemes for SchemeRegistry from WebProcessPool to LegacyGlobalSettings
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, ews-watchlist, ggaren, mitz, mkwst, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch youennf: review+

Alex Christensen
Reported 2019-09-24 16:18:50 PDT
Move schemes for SchemeRegistry from WebProcessPool to LegacyGlobalSettings
Attachments
Patch (20.79 KB, patch)
2019-09-24 16:20 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.95 KB, patch)
2019-11-07 14:39 PST, Alex Christensen 		youennf: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-09-24 16:20:18 PDT
Created attachment 379511 [details] Patch
Tim Horton
Comment 2 2019-09-24 16:33:23 PDT
This seems wrong for the case where there are multiple webkit clients in a given process
Alex Christensen
Comment 3 2019-11-07 14:39:41 PST
Created attachment 383074 [details] Patch
Alex Christensen
Comment 4 2019-11-08 03:29:00 PST
(In reply to Tim Horton from comment #2) > This seems wrong for the case where there are multiple webkit clients in a > given process This is SPI-only, it's only used from WKContextRegisterURLSchemeAsSecure and WKContextRegisterURLSchemeAsBypassingContentSecurityPolicy, and that one client intends them to be global. If you think it would be significantly better I could deprecate those two SPIs and make a class method replacement, but I don't think that's necessary.
Radar WebKit Bug Importer
Comment 6 2019-11-08 13:18:16 PST
<rdar://problem/57032146>
mitz
Comment 7 2019-11-08 13:34:13 PST
Comment on attachment 383074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383074&action=review > Source/WebKit/ChangeLog:8 > + The current users of the SPI to set these only have one WebProcessPool, so they intend these settings to be global. What if there are other WebKit clients in the same address space that have their own process pools?
Note You need to log in before you can comment on or make changes to this bug.