Bug 202167

Summary: [iPadOS] [DataActivation] Focus moves away after focusing input fields on www.att.com
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: FormsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix macOS builds
none
Patch for landing
wenson_hsieh: commit-queue+
Patch for landing
none
Patch none

Wenson Hsieh
Reported 2019-09-24 13:37:54 PDT
<rdar://problem/55185021>
Attachments
Patch (19.79 KB, patch)
2019-09-24 15:06 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix macOS builds (20.44 KB, patch)
2019-09-24 15:19 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.42 KB, patch)
2019-09-24 15:34 PDT, Wenson Hsieh 		wenson_hsieh: commit-queue+
DetailsFormatted DiffDiff
Patch for landing (20.42 KB, patch)
2019-09-24 15:35 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (21.88 KB, patch)
2019-09-24 17:28 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-09-24 15:06:07 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2019-09-24 15:19:12 PDT
Created attachment 379500 [details] Fix macOS builds
Tim Horton
Comment 3 2019-09-24 15:29:01 PDT
Comment on attachment 379500 [details] Fix macOS builds View in context: https://bugs.webkit.org/attachment.cgi?id=379500&action=review > Source/WebKit/ChangeLog:48 > + DataActivation. However, this also fixes various cases known bugs that are otherwise fixed in Safari only, via various cases known bugs > Source/WTF/wtf/spi/darwin/dyldSPI.h:49 > +#define DYLD_IOS_VERSION_13_1 0x000D0100 .2 > Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:329 > + static bool isDataActivation = applicationBundleIsEqualTo("com.apple.DataActivation"_s); I have some bizarre vague recollection that there might be second bundle ID for some reason? Maybe not anymore.
Wenson Hsieh
Comment 4 2019-09-24 15:32:50 PDT
Comment on attachment 379500 [details] Fix macOS builds View in context: https://bugs.webkit.org/attachment.cgi?id=379500&action=review >> Source/WebKit/ChangeLog:48 >> + DataActivation. However, this also fixes various cases known bugs that are otherwise fixed in Safari only, via > > various cases known bugs Fixed! >> Source/WTF/wtf/spi/darwin/dyldSPI.h:49 >> +#define DYLD_IOS_VERSION_13_1 0x000D0100 > > .2 Fixed! >> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:329 >> + static bool isDataActivation = applicationBundleIsEqualTo("com.apple.DataActivation"_s); > > I have some bizarre vague recollection that there might be second bundle ID for some reason? Maybe not anymore. 😧 (We chatted offline about this briefly, and it *appears* to no longer be the case)
Wenson Hsieh
Comment 5 2019-09-24 15:34:29 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 6 2019-09-24 15:35:24 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 7 2019-09-24 17:28:55 PDT
Created attachment 379518 [details] Patch
WebKit Commit Bot
Comment 8 2019-09-25 09:01:45 PDT
Comment on attachment 379518 [details] Patch Clearing flags on attachment: 379518 Committed r250345: <https://trac.webkit.org/changeset/250345>
WebKit Commit Bot
Comment 9 2019-09-25 09:01:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.