Bug 202146

Summary: We should initialize WebProcessPool::m_hiddenPageThrottlingTimer before using it.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: WebKit2Assignee: Mark Lam <mark.lam>
Status: RESOLVED INVALID    
Severity: Normal CC: cdumez, ggaren, rmorisset, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. mark.lam: review-

Mark Lam
Reported 2019-09-24 08:49:24 PDT
...
Attachments
proposed patch. (3.15 KB, patch)
2019-09-24 08:54 PDT, Mark Lam 		mark.lam: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-09-24 08:54:48 PDT
Created attachment 379455 [details] proposed patch.
Robin Morisset
Comment 2 2019-09-24 09:17:04 PDT
Comment on attachment 379455 [details] proposed patch. r=me
Chris Dumez
Comment 3 2019-09-24 09:18:13 PDT
Comment on attachment 379455 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=379455&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:232 > + , m_hiddenPageThrottlingAutoIncreasesCounter([this](RefCounterEvent) { m_hiddenPageThrottlingTimer.startOneShot(0_s); }) The RefCounter constructor does not run the lambda it is being given so I don't understand the problem.
Mark Lam
Comment 4 2019-09-24 09:22:03 PDT
Comment on attachment 379455 [details] proposed patch. I think Chris meant to r- this patch. This is not an issue after all. I just didn't look carefully enough at the code. Sorry for the noise.
Note You need to log in before you can comment on or make changes to this bug.