Bug 202099

Summary: testmasm: integer operands loaded as unsigned values
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, justin_michaud, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199891
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2019-09-23 01:15:52 PDT
testmasm: integer operands loaded as unsigned values
Attachments
Patch (4.43 KB, patch)
2019-09-23 01:21 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2019-09-23 01:20:05 PDT
../../Source/JavaScriptCore/assembler/testmasm.cpp: In function ‘void {anonymous}::testBranchTestBit32RegReg()’: ../../Source/JavaScriptCore/assembler/testmasm.cpp:105:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare] if ((_actual) == (_expected)) \ ~~~~~~~~~~^~~~~~~~~~~~~~ ../../Source/JavaScriptCore/assembler/testmasm.cpp:105:23: note: in definition of macro ‘CHECK_EQ’ if ((_actual) == (_expected)) \ ^~
Zan Dobersek
Comment 2 2019-09-23 01:21:49 PDT
Created attachment 379360 [details] Patch
Mark Lam
Comment 3 2019-09-23 07:01:32 PDT
Comment on attachment 379360 [details] Patch r=me
Zan Dobersek
Comment 4 2019-09-23 07:08:10 PDT
Comment on attachment 379360 [details] Patch Clearing flags on attachment: 379360 Committed r250232: <https://trac.webkit.org/changeset/250232>
Zan Dobersek
Comment 5 2019-09-23 07:08:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-23 07:09:20 PDT
<rdar://problem/55621894>
Note You need to log in before you can comment on or make changes to this bug.