Bug 202080

Summary: Reduce use of SessionID::defaultSessionID() in WebKit
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, dbates, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, japhet, kangil.han, toyoshim, webkit-bug-importer, youennf, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202086
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2019-09-21 14:29:13 PDT
Reduce use of SessionID::defaultSessionID() in WebKit.
Attachments
Patch (36.84 KB, patch)
2019-09-21 14:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (36.96 KB, patch)
2019-09-21 22:13 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-21 14:32:01 PDT
Created attachment 379322 [details] Patch
Alex Christensen
Comment 2 2019-09-21 21:35:55 PDT
Comment on attachment 379322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379322&action=review > Source/WebCore/Modules/websockets/WebSocketChannel.cpp:109 > + if (frame && page) { We should probably return ConnectStatus::KO if this is false.
Chris Dumez
Comment 3 2019-09-21 21:54:41 PDT
Comment on attachment 379322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379322&action=review >> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:109 >> + if (frame && page) { > > We should probably return ConnectStatus::KO if this is false. I was worried about changing behavior in a refactoring patch but I can try.
Chris Dumez
Comment 4 2019-09-21 22:13:12 PDT
Created attachment 379338 [details] Patch
Chris Dumez
Comment 5 2019-09-21 23:04:52 PDT
Comment on attachment 379338 [details] Patch Clearing flags on attachment: 379338 Committed r250196: <https://trac.webkit.org/changeset/250196>
Chris Dumez
Comment 6 2019-09-21 23:04:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-09-21 23:05:17 PDT
<rdar://problem/55597185>
Note You need to log in before you can comment on or make changes to this bug.