Bug 202059

Summary:

Move HSTS storage directory to LegacyGlobalSettings

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, cdumez, cgarcia, ews-watchlist, gustavo, thorton, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	thorton: review+

Alex Christensen

Reported 2019-09-20 14:55:22 PDT

Move HSTS storage directory to LegacyGlobalSettings

Attachments
Patch (5.69 KB, patch) 2019-09-20 14:55 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (6.80 KB, patch) 2019-09-20 23:04 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (6.98 KB, patch) 2019-09-24 06:28 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (6.98 KB, patch) 2019-09-24 06:33 PDT, Alex Christensen	thorton: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2019-09-20 14:55:53 PDT

Created attachment 379273 [details] Patch

Alex Christensen

Comment 2 2019-09-20 23:04:04 PDT

Created attachment 379309 [details] Patch

EWS Watchlist

Comment 3 2019-09-20 23:04:36 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Carlos Garcia Campos

Comment 4 2019-09-23 02:47:46 PDT

Comment on attachment 379309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379309&action=review > Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:-331 > - if (!webkit_website_data_manager_is_ephemeral(priv->websiteDataManager.get())) > - configuration.setHSTSStorageDirectory(FileSystem::stringFromFileSystemRepresentation(webkit_website_data_manager_get_hsts_cache_directory(priv->websiteDataManager.get()))); I guess we still need to set this in LegacyGlobalSettings to keep it working for now.

Alex Christensen

Comment 5 2019-09-24 06:28:13 PDT

Created attachment 379443 [details] Patch

Alex Christensen

Comment 6 2019-09-24 06:29:35 PDT

All right. It would probably be beneficial for gtk to move it to not have anything to do with LegacyGlobalSettings, but that's your decision.

Alex Christensen

Comment 7 2019-09-24 06:33:42 PDT

Created attachment 379445 [details] Patch

Alex Christensen

Comment 8 2019-09-24 11:54:50 PDT

http://trac.webkit.org/r250312