Bug 202056

Summary:

Fix WPT test html/browsers/offline/application-cache-api/api_swapcache_error.https.html

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dbates, ews-watchlist, japhet, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2019-09-20 14:05:28 PDT

null-check document in ApplicationCacheGroup::postListenerTask

Attachments
Patch (1.55 KB, patch) 2019-09-20 14:06 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (11.84 KB, patch) 2019-09-20 22:41 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (12.12 KB, patch) 2019-09-20 22:52 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (12.26 KB, patch) 2019-09-21 00:31 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2019-09-20 14:06:22 PDT

Created attachment 379268 [details] Patch

Alex Christensen

Comment 2 2019-09-20 14:06:44 PDT

See https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r250139%20(6810)/results.html for an example of this crash.

Alexey Proskuryakov

Comment 3 2019-09-20 16:53:57 PDT

Comment on attachment 379268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379268&action=review > Source/WebCore/ChangeLog:3 > + null-check document in ApplicationCacheGroup::postListenerTask Is this related to rdar://problem/55523986? A null check probably wouldn't be the right fix if it is.

Alex Christensen

Comment 4 2019-09-20 22:41:22 PDT

Created attachment 379307 [details] Patch

Alex Christensen

Comment 5 2019-09-20 22:52:58 PDT

Created attachment 379308 [details] Patch

Alex Christensen

Comment 6 2019-09-21 00:31:33 PDT

Created attachment 379314 [details] Patch

WebKit Commit Bot

Comment 7 2019-09-23 22:25:18 PDT

Comment on attachment 379314 [details] Patch Clearing flags on attachment: 379314 Committed r250283: <https://trac.webkit.org/changeset/250283>