Summary: | [Pointer Events] touch-action set to pan-x or pan-y alone should disable scrolling altogether if the intial gesture is in the disallowed direction | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, repstein, thorton, tobi, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antoine Quint
2019-09-20 13:03:09 PDT
Created attachment 379262 [details]
Patch
Committed r250183: <https://trac.webkit.org/changeset/250183> This appears to have regressed several layout tests: fast/scrolling/ios/reconcile-layer-position-recursive.html fast/scrolling/ios/click-events-during-momentum-scroll-in-main-frame.html fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-main-frame.html (In reply to Wenson Hsieh from comment #4) > This appears to have regressed several layout tests: > > fast/scrolling/ios/reconcile-layer-position-recursive.html > fast/scrolling/ios/click-events-during-momentum-scroll-in-main-frame.html > fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in- > main-frame.html That said, these are currently passing on our internal testers also running iOS 13, so maybe it’s an opensource-only (ENABLE(TOUCH_EVENTS)-related) failure? (In reply to Wenson Hsieh from comment #5) > (In reply to Wenson Hsieh from comment #4) > > This appears to have regressed several layout tests: > > > > fast/scrolling/ios/reconcile-layer-position-recursive.html > > fast/scrolling/ios/click-events-during-momentum-scroll-in-main-frame.html > > fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in- > > main-frame.html > > That said, these are currently passing on our internal testers also running > iOS 13, so maybe it’s an opensource-only (ENABLE(TOUCH_EVENTS)-related) > failure? Reopening bug due to above test regressions. Created attachment 379591 [details]
Fixes the layout tests
(In reply to Wenson Hsieh from comment #7) > Created attachment 379591 [details] > Fixes the layout tests I tested this against a non-internal iOS 13 SDK, and it seems to fix these three failing tests. Comment on attachment 379591 [details] Fixes the layout tests Clearing flags on attachment: 379591 Committed r250373: <https://trac.webkit.org/changeset/250373> All reviewed patches have been landed. Closing bug. Thanks Wenson! *** Bug 202531 has been marked as a duplicate of this bug. *** |