Bug 202028

Summary: Remove unused storage paths on APIProcessPoolConfiguration
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cdumez, cgarcia, ews-watchlist, gustavo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch cdumez: review+

Alex Christensen
Reported 2019-09-19 22:22:49 PDT
Remove unused storage paths on APIProcessPoolConfiguration
Attachments
Patch (31.76 KB, patch)
2019-09-19 22:24 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (31.84 KB, patch)
2019-09-19 22:38 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (32.88 KB, patch)
2019-09-19 22:48 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (32.65 KB, patch)
2019-09-19 23:38 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (32.85 KB, patch)
2019-09-19 23:54 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (32.85 KB, patch)
2019-09-19 23:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (33.41 KB, patch)
2019-09-20 05:24 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-09-19 22:24:32 PDT
Created attachment 379205 [details] Patch
Alex Christensen
Comment 2 2019-09-19 22:38:33 PDT
Created attachment 379208 [details] Patch
EWS Watchlist
Comment 3 2019-09-19 22:39:22 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 4 2019-09-19 22:48:58 PDT
Created attachment 379211 [details] Patch
Alex Christensen
Comment 5 2019-09-19 23:38:39 PDT
Created attachment 379214 [details] Patch
Alex Christensen
Comment 6 2019-09-19 23:54:04 PDT
Created attachment 379216 [details] Patch
Alex Christensen
Comment 7 2019-09-19 23:55:45 PDT
Created attachment 379217 [details] Patch
Alex Christensen
Comment 8 2019-09-20 05:24:11 PDT
Created attachment 379232 [details] Patch
Chris Dumez
Comment 9 2019-09-20 07:54:50 PDT
Comment on attachment 379232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379232&action=review > Source/WebKit/NetworkProcess/cache/NetworkCache.h:173 > + const String& storageDirectory() { return m_storageDirectory; } Why isn’t this const?
Alex Christensen
Comment 10 2019-09-20 13:12:07 PDT
It should be! http://trac.webkit.org/r250143
Radar WebKit Bug Importer
Comment 11 2019-09-20 13:13:19 PDT
<rdar://problem/55569594>
Note You need to log in before you can comment on or make changes to this bug.