Bug 202027 – Remove some support for < iOS 13

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Keith Rollin]

Remove some support for iOS versions less than 13.0. 

Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 130000. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.

After version checks have been removed, there are some cases where the preprocessor conditional looks like "#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)". These can be collapsed into "#if PLATFORM(COCOA)". This additional cleanup will be performed in a subsequent patch.

This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Joe Pecoraro was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process.

[Radar WebKit Bug Importer]

<rdar://problem/55547109>

[Keith Rollin]

Created attachment 379206 [details]
Patch

[Alex Christensen]

Comment on attachment 379206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379206&action=review

> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:222
> +#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)

These should just be PLATFORM(COCOA)

[Keith Rollin]

I noted in my comment that I was going to perform that cleanup later. I'd like to keep each patch focussed on one type of change.

[Keith Rollin]

So can I land it now anyway?

[Alex Christensen]

I don't see any reason to do this in two changes.  It's not hard to follow, and it would merge cleanly if we merged this to a branch.

[Keith Rollin]

My reason is that this current patch is part of a much larger body of work, and I don't want to distract myself by going down other paths at the point. I have a process to manage all these details. Getting to the change you want is part of that, but it comes later.

[Alex Christensen]

Comment on attachment 379206 [details]
Patch

I'm assuming that means you have a long train of git commits that would need rebasing if we changed this.  Whatever.  You should have a work flow that is more open to review changing things.

[WebKit Commit Bot]

Comment on attachment 379206 [details]
Patch

Clearing flags on attachment: 379206

Committed r250171: <https://trac.webkit.org/changeset/250171>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.