Bug 201999

Summary: [EWS] JSC queues should re-build ToT and compare results on build failure
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, aperez, ap, clopez, commit-queue, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202170
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-09-19 13:18:36 PDT
When JSC queue fails to build-jsc with the patch, it should re-build ToT and compare results to check if the failure is new or pre-existing.
Attachments
Patch (4.41 KB, patch)
2019-09-19 13:38 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-09-19 13:38:41 PDT
Created attachment 379159 [details] Patch
Aakash Jain
Comment 3 2019-09-19 13:52:43 PDT
Another sample run for 'success': https://ews-build.webkit-uat.org/#/builders/17/builds/3994
Aakash Jain
Comment 4 2019-09-19 13:53:55 PDT
Note that this patch is only for building JSC, jsc-testing logic will be added/fixed in subsequent patches.
Jonathan Bedard
Comment 5 2019-09-19 16:29:33 PDT
Comment on attachment 379159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379159&action=review > Tools/BuildSlaveSupport/ews-build/factories.py:124 > self.addStep(UnApplyPatchIfRequired()) Is this not dynamically added as well?
Aakash Jain
Comment 6 2019-09-19 17:37:32 PDT
Comment on attachment 379159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379159&action=review >> Tools/BuildSlaveSupport/ews-build/factories.py:124 >> self.addStep(UnApplyPatchIfRequired()) > > Is this not dynamically added as well? These would be removed in subsequent patches. I haven’t started working on these tests yet.
WebKit Commit Bot
Comment 7 2019-09-20 18:07:56 PDT
Comment on attachment 379159 [details] Patch Clearing flags on attachment: 379159 Committed r250174: <https://trac.webkit.org/changeset/250174>
WebKit Commit Bot
Comment 8 2019-09-20 18:07:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-09-20 18:08:15 PDT
<rdar://problem/55579180>
Note You need to log in before you can comment on or make changes to this bug.