Bug 201982 – [GTK][WPE] EXIF orientation tests are failing since added in r249364 - "EXIF orientation should be respected when rendering images"

• Component: WebKitGTK
• Status: NEW

[Miguel Gomez]

These are the tests failing both for WPE and GTK.

fast/images/exif-orientation-background.html [ ImageOnlyFailure ]
fast/images/exif-orientation-canvas.html [ ImageOnlyFailure ]
fast/images/exif-orientation-composited.html [ ImageOnlyFailure ]
fast/images/exif-orientation-content.html [ ImageOnlyFailure ]
fast/images/exif-orientation-element-object-fit.html [ ImageOnlyFailure ]
fast/images/exif-orientation-element.html [ ImageOnlyFailure ]
fast/images/exif-orientation-image-document.html [ ImageOnlyFailure ]
fast/images/exif-orientation-image-object.html [ ImageOnlyFailure ]
fast/images/exif-orientation-svg-feimage.html [ ImageOnlyFailure ]
fast/images/exif-orientation-svg-image.html [ ImageOnlyFailure ]

These is the output of one of the tests that shows the problem:
https://build.webkit.org/results/WPE%20Linux%2064-bit%20Release%20(Tests)/r250087%20(15371)/fast/images/exif-orientation-element-diffs.html

Seems that we are not calculating the proper width and height for images rotated 90 degrees CW and CCW.

[Diego Pino]

New EXIF related tests are failing showing the same kind of error message: "EXIF orientation should be respected". The tests are the following:

Since added in r253610:

* fast/images/exif-orientation-webgl-texture.html

Since added in r254187:

* fast/images/image-orientation-dynamic-from-image.html
* fast/images/image-orientation-dynamic-none.html
* fast/images/image-orientation-none.html

[Diego Pino]

More EXIF orientation related tests are failing since added in r254841:
 
  * fast/images/exif-orientation-background-image-no-repeat.html
  * fast/images/exif-orientation-background-image-repeat.html
  * fast/images/exif-orientation-border-image.html

[Lauro Moura]

This is also affecting fast/images/image-orientation-none-canvas.html from bug209849.

[Diego Pino]

Passing since r260016 (https://trac.webkit.org/changeset/260050/webkit):

  fast/images/image-orientation-dynamic-none.html
  fast/images/image-orientation-none.html
  fast/images/image-orientation-none-canvas.html

[Michael Catanzaro]

Lauro fixed most of these (but not all) in bug #95299.

[Lauro Moura]

(In reply to Michael Catanzaro from comment #5)
> Lauro fixed most of these (but not all) in bug #95299.

Thanks for applying #95299, Michael (did not have time due to other issues). It's on my table today to update what's missing from that bug.

[Lauro Moura]

Remaining issues after bug95299:

fast/images/exif-orientation-background-image-repeat.html
fast/images/exif-orientation-border-image.html

Summary of failures:

fast/images/exif-orientation-background-image-repeat.html

* No orientation applied when:
  * Flipped horizontally
  * Flipped vertically
  * Rotated 180°
  * Rotated 90° CCW
* "Translated" halfway to the left
  * Rotated 90° CW
  * Rotated 90° CCW and flipped vertically
  * Rotated 90° CW and flipped vertically

fast/images/exif-orientation-border-image.html

* Corrupted border:
  * All 90° rotations
* Some sections not transformed
  * Flipped horizontally
  * Flipped vertically
  * Rotated 180°

[Dawn Morningstar]

fast/images/exif-orientation-background-image-repeat.html
is still a failure, expectation may need to be set to clear up dashboard until this issue is resolved

[Milan Crha]

Downstream bug report using WebKitGTK 2.36.0:
https://gitlab.gnome.org/GNOME/evolution/-/issues/1897

it includes a sample image, if needed.

[Milan Crha]

I see this is marked as WPE; I'm not sure it's related for the evolution bug.