Bug 201976

Summary: [Win][MiniBrowser] Use _com_ptr_t methods instead of calling QueryInterface explictly
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, don.olmstead, pvollan, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2019-09-19 04:18:10 PDT
[Win][MiniBrowser] Use _com_ptr_t methods instead of calling QueryInterface explictly
Attachments
Patch (17.88 KB, patch)
2019-09-19 04:28 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-09-19 04:28:41 PDT
Created attachment 379119 [details] Patch
Brent Fulgham
Comment 2 2019-09-19 20:15:36 PDT
Comment on attachment 379119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379119&action=review > Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.h:59 > +_COM_SMARTPTR_TYPEDEF(IWebViewPrivate3, IID_IWebViewPrivate3); Nice!
Fujii Hironori
Comment 3 2019-09-19 20:20:21 PDT
Comment on attachment 379119 [details] Patch Clearing flags on attachment: 379119 Committed r250117: <https://trac.webkit.org/changeset/250117>
Fujii Hironori
Comment 4 2019-09-19 20:20:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-09-19 20:21:16 PDT
<rdar://problem/55546007>
Note You need to log in before you can comment on or make changes to this bug.