Bug 201976 - [Win][MiniBrowser] Use _com_ptr_t methods instead of calling QueryInterface explictly
Summary: [Win][MiniBrowser] Use _com_ptr_t methods instead of calling QueryInterface e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-19 04:18 PDT by Fujii Hironori
Modified: 2019-09-19 20:21 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.88 KB, patch)
2019-09-19 04:28 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-09-19 04:18:10 PDT 
[Win][MiniBrowser] Use _com_ptr_t methods instead of calling QueryInterface explictly
Comment 1 Fujii Hironori 2019-09-19 04:28:41 PDT 
Created attachment 379119 [details]
Patch
Comment 2 Brent Fulgham 2019-09-19 20:15:36 PDT 
Comment on attachment 379119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379119&action=review

> Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.h:59
> +_COM_SMARTPTR_TYPEDEF(IWebViewPrivate3, IID_IWebViewPrivate3);

Nice!
Comment 3 Fujii Hironori 2019-09-19 20:20:21 PDT 
Comment on attachment 379119 [details]
Patch

Clearing flags on attachment: 379119

Committed r250117: <https://trac.webkit.org/changeset/250117>
Comment 4 Fujii Hironori 2019-09-19 20:20:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-09-19 20:21:16 PDT 
<rdar://problem/55546007>