Bug 201948

Summary: Web Inspector: console assertion when pressing up/down in empty console log view
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix hi: review+

Joseph Pecoraro
Reported 2019-09-18 15:04:51 PDT
console assertion when pressing up/down in empty console log view Steps to Reproduce: 1. Open Web Inspector 2. js> 123 3. Select the "123" output view 4. Clear the console (⌘K) 5. Press Up or Down => Assert in inspector² Notes: Simple fix, but maybe we should beep.
Attachments
[PATCH] Proposed Fix (2.96 KB, patch)
2019-09-18 17:17 PDT, Joseph Pecoraro 		hi: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-09-18 17:17:02 PDT
Created attachment 379088 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 2 2019-09-18 17:25:22 PDT
Comment on attachment 379088 [details] [PATCH] Proposed Fix rs=me Can you actually write somewhere what the assertion message/location actually was? I'm guessing it's the `console.assert(message)` inside `WI.LogContentView.prototype._updateMessagesSelection`?
Joseph Pecoraro
Comment 3 2019-09-18 17:34:32 PDT
(In reply to Devin Rousso from comment #2) > Comment on attachment 379088 [details] > [PATCH] Proposed Fix > > rs=me > > Can you actually write somewhere what the assertion message/location > actually was? I'm guessing it's the `console.assert(message)` inside > `WI.LogContentView.prototype._updateMessagesSelection`? Yep that was it. I'll add that to the ChangeLog.
Joseph Pecoraro
Comment 4 2019-09-18 18:45:56 PDT
https://trac.webkit.org/r250076
Radar WebKit Bug Importer
Comment 5 2019-09-18 18:46:19 PDT
<rdar://problem/55502716>
Note You need to log in before you can comment on or make changes to this bug.