Bug 201928

Summary: EWS should run resultsdbpy tests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207304
https://bugs.webkit.org/show_bug.cgi?id=261071
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Aakash Jain
Reported 2019-09-18 11:53:09 PDT
EWS should run resultsdbpy tests. This would make sure that someone doesn't accidentally break resultsdbpy. See: https://trac.webkit.org/browser/webkit/trunk/Tools/resultsdbpy/resultsdbpy/run-tests
Attachments
Patch (6.05 KB, patch)
2020-02-05 17:30 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (7.19 KB, patch)
2020-02-05 17:45 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (7.58 KB, patch)
2020-02-06 07:38 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (7.73 KB, patch)
2020-02-06 17:03 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-09-18 11:53:45 PDT
<rdar://problem/55109441>
Jonathan Bedard
Comment 2 2020-02-05 17:30:00 PST
Created attachment 389909 [details] Patch
Aakash Jain
Comment 3 2020-02-05 17:35:53 PST
Looks good to me. unit-tests needs minor change. Can you also deploy it on uat instance and verify.
Jonathan Bedard
Comment 4 2020-02-05 17:45:08 PST
Created attachment 389917 [details] Patch
Aakash Jain
Comment 5 2020-02-06 04:11:52 PST
services_paths in CheckPatchRelevance needs to be updated as well. At: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps.py#L237
Jonathan Bedard
Comment 6 2020-02-06 07:38:21 PST
Created attachment 389955 [details] Patch
Jonathan Bedard
Comment 7 2020-02-06 17:03:48 PST
Created attachment 390032 [details] Patch
Aakash Jain
Comment 8 2020-02-06 18:37:25 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/1/builds/522
WebKit Commit Bot
Comment 9 2020-02-07 08:19:09 PST
Comment on attachment 390032 [details] Patch Clearing flags on attachment: 390032 Committed r256021: <https://trac.webkit.org/changeset/256021>
WebKit Commit Bot
Comment 10 2020-02-07 08:19:11 PST
All reviewed patches have been landed. Closing bug.
Aakash Jain
Comment 11 2020-02-11 05:14:53 PST
Deployed on production server, seems to be working fine, e.g.: https://ews-build.webkit.org/#/builders/20/builds/13802
Jonathan Bedard
Comment 12 2020-02-11 07:46:39 PST
(In reply to Aakash Jain from comment #11) > Deployed on production server, seems to be working fine, e.g.: > https://ews-build.webkit.org/#/builders/20/builds/13802 Great! I think that there is a question about if we should enable the full set of database tests (which take about 20 minutes), and I wanted to mention that possibility here so we have a record of the reason why I chose to only run the mock tests, which is basically because the full set of database tests take too long.
Note You need to log in before you can comment on or make changes to this bug.