Bug 201916

Summary: Drop FrameLoaderClient::sessionID()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, dbates, ews-watchlist, ggaren, japhet, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2019-09-18 08:33:50 PDT
Drop FrameLoaderClient::sessionID(). The Frame can get the sessionID from its page (Which is what the FrameLoaderClient::sessionID() ended up doing) and other call sites at WebKit2 layer can get the sessionID from the WebProcess singleton.
Attachments
Patch (13.22 KB, patch)
2019-09-18 08:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (14.63 KB, patch)
2019-09-18 09:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-18 08:36:07 PDT
Created attachment 379039 [details] Patch
Chris Dumez
Comment 2 2019-09-18 09:14:14 PDT
Created attachment 379041 [details] Patch
Geoffrey Garen
Comment 3 2019-09-18 10:09:37 PDT
Comment on attachment 379041 [details] Patch r=me
Chris Dumez
Comment 4 2019-09-18 10:14:20 PDT
Comment on attachment 379041 [details] Patch Clearing flags on attachment: 379041 Committed r250043: <https://trac.webkit.org/changeset/250043>
Chris Dumez
Comment 5 2019-09-18 10:14:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-18 10:15:19 PDT
<rdar://problem/55482907>
Radar WebKit Bug Importer
Comment 7 2019-09-18 10:15:23 PDT
<rdar://problem/55482910>
Note You need to log in before you can comment on or make changes to this bug.