Bug 201889

Summary: Follow-up after String.codePointAt optimization
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2019-09-17 16:36:58 PDT
Follow-up after String.codePointAt optimization
Attachments
Patch (13.57 KB, patch)
2019-09-17 16:38 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-09-17 16:38:32 PDT
Created attachment 379006 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-09-17 16:39:23 PDT
<rdar://problem/55459325>
Yusuke Suzuki
Comment 3 2019-09-17 16:41:15 PDT
Comment on attachment 379006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379006&action=review > Source/JavaScriptCore/ChangeLog:11 > + 2. Check BadType in String.codePointAt, String.charAt, and String.charCodeAt. For now, I'm just fixing these three things. It would be profitable to see the other things, but it involves more changes (like, check whether it accepts UntypedUse etc.).
Yusuke Suzuki
Comment 4 2019-09-17 17:31:56 PDT
Committed r250004: <https://trac.webkit.org/changeset/250004>
Note You need to log in before you can comment on or make changes to this bug.