Bug 201873

Summary: run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test()
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, jbedard, joepeck, rniwa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193772
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2019-09-17 09:45:25 PDT 
Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test() in run-webkit-tests.

This breaks traditional leaks checking (added in Bug 193772) and document leak checking at the end of each testing shard.  (This regressed sometime after the fix for Bug 193772 was landed.  I think it was related to fixing test timeouts on bots.)
Comment 1 Radar WebKit Bug Importer 2019-09-17 09:45:54 PDT 
<rdar://problem/55442387>
Comment 2 David Kilzer (:ddkilzer) 2019-09-17 09:47:50 PDT 
Created attachment 378971 [details]
Patch v1
Comment 3 WebKit Commit Bot 2019-09-17 10:50:33 PDT 
Comment on attachment 378971 [details]
Patch v1

Clearing flags on attachment: 378971

Committed r249965: <https://trac.webkit.org/changeset/249965>
Comment 4 WebKit Commit Bot 2019-09-17 10:50:35 PDT 
All reviewed patches have been landed.  Closing bug.