Bug 201859

Summary: REGRESSION (r249923): ASSERTION FAILED: sessionID == WebProcess::singleton().sessionID() in WebCore::SWClientConnection *WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID)
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, berto, cdumez, cgarcia, commit-queue, ews-watchlist, ggaren, gustavo, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201830
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ryan Haddad
Reported 2019-09-16 21:15:53 PDT
The following API test is timing out / failing an assertion added with https://trac.webkit.org/changeset/249923/webkit TestWebKitAPI.WebKit.PrivateBrowsingPushStateNoHistoryCallback _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. ASSERTION FAILED: sessionID == WebProcess::singleton().sessionID() /Volumes/Data/slave/mojave-debug/build/Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp(65) : virtual WebCore::SWClientConnection *WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID) 1 0x319c51089 WTFCrash 2 0x10658296b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10772003c WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID) 4 0x1079aca22 WebKit::WebPage::updateThrottleState()::$_4::operator()() const 5 0x1079ac9c9 WTF::Detail::CallableWrapper<WebKit::WebPage::updateThrottleState()::$_4, void>::call() 6 0x319c7db9a WTF::Function<void ()>::operator()() const 7 0x319ceecf5 WTF::RunLoop::performWork() 8 0x319cf009e WTF::RunLoop::performWork(void*) 9 0x7fff3787c683 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 10 0x7fff3787c629 __CFRunLoopDoSource0 11 0x7fff3785ffeb __CFRunLoopDoSources0 12 0x7fff3785f5b5 __CFRunLoopRun 13 0x7fff3785eebe CFRunLoopRunSpecific 14 0x7fff39ac37df -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 15 0x7fff39ac36b4 -[NSRunLoop(NSRunLoop) run] 16 0x7fff639ee077 _xpc_objc_main 17 0x7fff639edb79 _xpc_copy_xpcservice_dictionary 18 0x106cd73e5 WebKit::XPCServiceMain(int, char const**) 19 0x107cb0bfb WKXPCServiceMain 20 0x106576ea2 main 21 0x7fff637b53d5 start https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/4712/steps/run-api-tests/logs/stdio
Attachments
Patch (18.86 KB, patch)
2019-09-16 22:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (19.72 KB, patch)
2019-09-17 08:18 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.83 KB, patch)
2019-09-17 09:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-16 21:17:23 PDT
<rdar://problem/55426742>
Chris Dumez
Comment 2 2019-09-16 21:17:53 PDT
Looking.
Chris Dumez
Comment 3 2019-09-16 21:25:55 PDT
There is a WKPreferencesSetPrivateBrowsingEnabled() C SPI which still allows the view to change session without navigating :/
Chris Dumez
Comment 4 2019-09-16 22:02:49 PDT
Created attachment 378937 [details] Patch
Chris Dumez
Comment 5 2019-09-17 08:18:08 PDT
Created attachment 378964 [details] Patch
EWS Watchlist
Comment 6 2019-09-17 08:18:40 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Chris Dumez
Comment 7 2019-09-17 09:02:46 PDT
Created attachment 378967 [details] Patch
Chris Dumez
Comment 8 2019-09-17 10:12:11 PDT
Comment on attachment 378967 [details] Patch Clearing flags on attachment: 378967 Committed r249962: <https://trac.webkit.org/changeset/249962>
Chris Dumez
Comment 9 2019-09-17 10:12:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.