Bug 201846

Summary: Make all ScriptWrappable IsoHeap-ed
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alecflett, apinheiro, beidson, calvaris, cdumez, cfleizach, dbates, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, graouts, gyuyoung.kim, hta, jcraig, jdiggs, jer.noble, jsbell, kangil.han, kondapallykalyan, mark.lam, mmaxfield, pdr, philipj, repstein, sabouhallawa, samuel_white, schenney, sergio, tommyw, toyoshim, webkit-bug-importer, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
mark.lam: review+
Patch for landing, update for newly added Event, GPUUncapturedErrorEvent none

Yusuke Suzuki
Reported 2019-09-16 15:44:55 PDT
Make all ScriptWrappable IsoHeap-ed
Attachments
Patch (120.12 KB, patch)
2019-09-16 15:47 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (120.16 KB, patch)
2019-09-16 15:49 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Patch for landing, update for newly added Event, GPUUncapturedErrorEvent (127.00 KB, patch)
2019-09-18 03:22 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-09-16 15:47:21 PDT
Created attachment 378902 [details] Patch
Yusuke Suzuki
Comment 2 2019-09-16 15:49:01 PDT
Created attachment 378903 [details] Patch
Yusuke Suzuki
Comment 3 2019-09-16 15:53:48 PDT
Note that this does not cause Speedometer2 regression.
Mark Lam
Comment 4 2019-09-16 16:30:46 PDT
Comment on attachment 378903 [details] Patch r=me
Yusuke Suzuki
Comment 5 2019-09-16 16:34:27 PDT
I'll land this after I recheck this super carefully, and after I run the LLDB-based test to ensure the invariant.
Yusuke Suzuki
Comment 6 2019-09-18 03:22:16 PDT
Created attachment 379031 [details] Patch for landing, update for newly added Event, GPUUncapturedErrorEvent
Yusuke Suzuki
Comment 7 2019-09-18 03:25:53 PDT
Checked with https://bugs.webkit.org/show_bug.cgi?id=201890 's ad-hoc script. I would like to introduce such a test in a separate patch.
Yusuke Suzuki
Comment 8 2019-09-18 03:33:22 PDT
Committed r250030: <https://trac.webkit.org/changeset/250030>
Radar WebKit Bug Importer
Comment 9 2019-09-18 03:34:17 PDT
<rdar://problem/55472869>
Russell Epstein
Comment 10 2019-09-18 09:51:51 PDT
Reverted r250030 for reason: Cause of Recent Build Failures. Committed r250040: <https://trac.webkit.org/changeset/250040>
Yusuke Suzuki
Comment 11 2019-09-18 15:10:14 PDT
Committed r250060: <https://trac.webkit.org/changeset/250060>
Note You need to log in before you can comment on or make changes to this bug.