Bug 201843

Summary:

Update testharness.js from upstream for web-platform-tests

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, beidson, commit-queue, eric.carlson, ews-watchlist, ggaren, glenn, hta, jer.noble, jiewen_tan, jsbell, philipj, rniwa, ryanhaddad, sergio, tommyw, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=201808

Attachments:

Description	Flags
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews213 for win-future	none
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews213 for win-future	none
WIP Patch	none
WIP Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2019-09-16 14:54:48 PDT

Update testharness.js from upstream for web-platform-tests.

Attachments
WIP Patch (60.33 KB, patch) 2019-09-16 14:55 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews213 for win-future (13.65 MB, application/zip) 2019-09-16 16:24 PDT, EWS Watchlist	no flags	Details
WIP Patch (93.03 KB, patch) 2019-09-16 16:24 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews213 for win-future (13.97 MB, application/zip) 2019-09-16 17:45 PDT, EWS Watchlist	no flags	Details
WIP Patch (113.66 KB, patch) 2019-09-16 19:04 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (133.40 KB, patch) 2019-09-16 20:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (225.25 KB, patch) 2019-09-16 21:11 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (230.03 KB, patch) 2019-09-16 22:13 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (241.07 KB, patch) 2019-09-17 08:23 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (241.18 KB, patch) 2019-09-17 09:07 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (241.12 KB, patch) 2019-09-17 12:33 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-09-16 14:55:37 PDT

Created attachment 378898 [details] WIP Patch

EWS Watchlist

Comment 2 2019-09-16 16:23:47 PDT

Comment on attachment 378898 [details] WIP Patch Attachment 378898 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13037591 New failing tests: http/wpt/resource-timing/rt-initiatorType-other.html

EWS Watchlist

Comment 3 2019-09-16 16:24:01 PDT

Created attachment 378910 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Chris Dumez

Comment 4 2019-09-16 16:24:15 PDT

Created attachment 378911 [details] WIP Patch

EWS Watchlist

Comment 5 2019-09-16 17:45:40 PDT

Comment on attachment 378911 [details] WIP Patch Attachment 378911 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13037879 New failing tests: http/wpt/resource-timing/rt-initiatorType-other.html

EWS Watchlist

Comment 6 2019-09-16 17:45:51 PDT

Created attachment 378921 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Chris Dumez

Comment 7 2019-09-16 19:04:15 PDT

Created attachment 378926 [details] WIP Patch

Chris Dumez

Comment 8 2019-09-16 20:02:49 PDT

Created attachment 378930 [details] WIP Patch

Chris Dumez

Comment 9 2019-09-16 21:11:12 PDT

Created attachment 378933 [details] Patch

Chris Dumez

Comment 10 2019-09-16 22:13:15 PDT

Created attachment 378938 [details] Patch

Chris Dumez

Comment 11 2019-09-17 08:23:14 PDT

Created attachment 378965 [details] Patch

Chris Dumez

Comment 12 2019-09-17 09:07:33 PDT

Created attachment 378968 [details] Patch

Jiewen Tan

Comment 13 2019-09-17 11:41:35 PDT

Comment on attachment 378968 [details] Patch LGTM. r=me.

WebKit Commit Bot

Comment 14 2019-09-17 12:27:43 PDT

Comment on attachment 378968 [details] Patch Rejecting attachment 378968 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 378968, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=378968&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=201843&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 378968 from bug 201843. Fetching: https://bugs.webkit.org/attachment.cgi?id=378968 Failed to determine email address for ChangeLog. Either: set CHANGE_LOG_EMAIL_ADDRESS in your environment OR pass --email= on the command line OR set EMAIL_ADDRESS in your environment OR git users can set 'git config user.email' Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/commit-log-editor', '--print-log', u'/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog', u'/Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog']" exit_code: 1 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/commit-log-editor', '--print-log', u'/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog', u'/Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog']" exit_code: 1 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/commit-log-editor', '--print-log', u'/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog', u'/Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog']" exit_code: 1 Updating OpenSource From https://git.webkit.org/git/WebKit c9e932258e6..57abc5aa833 master -> origin/master Updating c9e932258e6..57abc5aa833 Fast-forward LayoutTests/ChangeLog | 37 ++++++++++ LayoutTests/platform/mac/TestExpectations | 17 +++++ .../animateMotion-remove-freeze-use-expected.svg | 6 ++ .../animations/animateMotion-remove-freeze-use.svg | 25 +++++++ .../animations/fill-remove-support-expected.txt | 60 ++++++++++++++++ .../svg/animations/fill-remove-support.html | 82 ++++++++++++++++++++++ .../animations/resources/fill-remove-support.svg | 11 +++ Source/WebCore/ChangeLog | 43 ++++++++++++ Source/WebCore/svg/SVGAnimateMotionElement.cpp | 9 +-- Source/WebKit/ChangeLog | 44 ++++++++++++ .../cache/CacheStorageEngineConnection.cpp | 70 +++++++++--------- .../cache/CacheStorageEngineConnection.h | 24 ++++--- .../cache/CacheStorageEngineConnection.messages.in | 20 +++--- .../WebProcess/Cache/WebCacheStorageConnection.cpp | 30 ++++---- .../WebProcess/Cache/WebCacheStorageConnection.h | 9 ++- .../WebProcess/Cache/WebCacheStorageProvider.cpp | 15 ++-- .../WebProcess/Cache/WebCacheStorageProvider.h | 3 +- 17 files changed, 412 insertions(+), 93 deletions(-) create mode 100644 LayoutTests/svg/animations/animateMotion-remove-freeze-use-expected.svg create mode 100644 LayoutTests/svg/animations/animateMotion-remove-freeze-use.svg create mode 100644 LayoutTests/svg/animations/fill-remove-support-expected.txt create mode 100644 LayoutTests/svg/animations/fill-remove-support.html create mode 100644 LayoutTests/svg/animations/resources/fill-remove-support.svg Full output: https://webkit-queues.webkit.org/results/13040575

Chris Dumez

Comment 15 2019-09-17 12:33:46 PDT

Created attachment 378978 [details] Patch

WebKit Commit Bot

Comment 16 2019-09-17 13:17:55 PDT

Comment on attachment 378978 [details] Patch Clearing flags on attachment: 378978 Committed r249977: <https://trac.webkit.org/changeset/249977>

WebKit Commit Bot

Comment 17 2019-09-17 13:17:57 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 18 2019-09-17 13:18:35 PDT

<rdar://problem/55450761>

Chris Dumez

Comment 19 2019-09-17 14:44:05 PDT

*** Bug 201661 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.