Bug 201820

Summary: Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, ap, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andres Gonzalez
Reported 2019-09-16 08:54:56 PDT
Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
Attachments
Patch (8.99 KB, patch)
2019-09-16 09:01 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2019-09-16 09:01:43 PDT
Created attachment 378863 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-09-16 09:58:37 PDT
<rdar://problem/55403307>
WebKit Commit Bot
Comment 3 2019-09-16 10:15:38 PDT
Comment on attachment 378863 [details] Patch Clearing flags on attachment: 378863 Committed r249904: <https://trac.webkit.org/changeset/249904>
WebKit Commit Bot
Comment 4 2019-09-16 10:15:39 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2019-09-17 09:15:36 PDT
Comment on attachment 378863 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378863&action=review > Source/WebCore/ChangeLog:3 > + Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client. What about versions of accessibility client that didn't have this change yet?
chris fleizach
Comment 6 2019-09-17 09:46:33 PDT
(In reply to Alexey Proskuryakov from comment #5) > Comment on attachment 378863 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378863&action=review > > > Source/WebCore/ChangeLog:3 > > + Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client. > > What about versions of accessibility client that didn't have this change yet? As long as this change gets into 13.2, we should be in lockstep
Note You need to log in before you can comment on or make changes to this bug.