Bug 201801

Summary: [Cocoa] Add a WKA extension point
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andy Estes
Reported 2019-09-14 18:32:49 PDT
[Cocoa] Add a WKA extension point
Attachments
Patch (2.39 KB, patch)
2019-09-14 18:34 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2019-09-14 18:34:31 PDT
Created attachment 378804 [details] Patch
Andy Estes
Comment 2 2019-09-14 18:34:53 PDT
rdar://problem/55372507
Radar WebKit Bug Importer
Comment 3 2019-09-14 18:35:13 PDT
<rdar://problem/55372554>
Sam Weinig
Comment 4 2019-09-14 18:43:24 PDT
Comment on attachment 378804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378804&action=review > Source/WebCore/ChangeLog:3 > + [Cocoa] Add a WKA extension point What is a WKA extension point? Why should we add one? > Source/WebCore/ChangeLog:11 > + * Modules/applepay/ApplePayRequestBase.cpp: > + (WebCore::requiresSupportedNetworks): > + (WebCore::convertAndValidate): How is this being tested?
Andy Estes
Comment 5 2019-09-17 10:12:27 PDT
(In reply to Sam Weinig from comment #4) > Comment on attachment 378804 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378804&action=review > > > Source/WebCore/ChangeLog:3 > > + [Cocoa] Add a WKA extension point > > What is a WKA extension point? Why should we add one? It's a place where WebKitAdditions can extend WebKit. The radar explains why we should add one. > > > Source/WebCore/ChangeLog:11 > > + * Modules/applepay/ApplePayRequestBase.cpp: > > + (WebCore::requiresSupportedNetworks): > > + (WebCore::convertAndValidate): > > How is this being tested? With a layout test, but it can't be included in this patch. It'll be part of a future patch that moves things from WebKitAdditions to open source.
WebKit Commit Bot
Comment 6 2019-09-17 10:46:10 PDT
Comment on attachment 378804 [details] Patch Clearing flags on attachment: 378804 Committed r249964: <https://trac.webkit.org/changeset/249964>
WebKit Commit Bot
Comment 7 2019-09-17 10:46:12 PDT
All reviewed patches have been landed. Closing bug.
Andy Estes
Comment 8 2019-09-17 11:12:48 PDT
Rolled out in r249967: <https://trac.webkit.org/changeset/249967>
Andy Estes
Comment 9 2019-09-18 00:16:17 PDT
Committed r250026: <https://trac.webkit.org/changeset/250026>
Note You need to log in before you can comment on or make changes to this bug.