Bug 201793

Summary: [GTK][WPE] Check for a Snap sandbox a bit harder
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKitGTKAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, fpizlo, mark.lam, mcatanzaro, pgriffis, svillar
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 201486    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2019-09-14 03:40:58 PDT
In a discussion with Patrick after bug #201486 we agreed that it may be a good thing to check a little bit more thoroughly whether we are running inside a Snap sandbox: instead of looking for a “SNAP” environment variable only, we can check also for the “SNAP_NAME” and “SNAP_REVISION” variables. The rationale is that “SNAP” is kind of a short variable and not completely unlikely to be set by an user without being inside a Snap container. Checking a couple of environment variables should be fine (it is very unlikely that they would be all set accidentally at the same time), and we don't want anyway to make complex checks anyway.
Attachments
Patch (1.60 KB, patch)
2019-09-14 03:53 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2019-09-14 03:53:11 PDT
Created attachment 378790 [details] Patch
Adrian Perez
Comment 2 2019-09-14 03:54:16 PDT
Added Patrick in CC, as he is our sandboxing expert, in case he wants to comment on this :)
Patrick Griffis
Comment 3 2019-09-14 14:58:47 PDT
Comment on attachment 378790 [details] Patch Looks good.
WebKit Commit Bot
Comment 4 2019-09-14 15:45:36 PDT
Comment on attachment 378790 [details] Patch Clearing flags on attachment: 378790 Committed r249882: <https://trac.webkit.org/changeset/249882>
WebKit Commit Bot
Comment 5 2019-09-14 15:45:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.