Bug 201779

Summary: results.webkit.org: Collapse results with the same version name
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, repstein, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-09-13 15:49:21 PDT
If a result has the same version name, and a different version number, we should collapse them the same way we do with differing SDKs.
Attachments
Patch (4.72 KB, patch)
2019-09-13 15:59 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (6.32 KB, patch)
2019-09-17 16:45 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.90 KB, patch)
2019-09-18 07:41 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (7.82 KB, patch)
2019-09-18 09:36 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (8.95 KB, patch)
2019-09-19 14:58 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.95 KB, patch)
2019-09-19 17:22 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2019-09-23 12:26 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.78 KB, patch)
2019-09-23 13:12 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-09-13 15:59:20 PDT
Created attachment 378757 [details] Patch
Jonathan Bedard
Comment 2 2019-09-13 16:23:14 PDT
Not entirely convinced this is the right change, adding bot watchers for input.
Jonathan Bedard
Comment 3 2019-09-17 16:45:35 PDT
Created attachment 379007 [details] Patch
Jonathan Bedard
Comment 4 2019-09-17 16:46:53 PDT
This change differentiates between E releases, even if they share a version name.
Jonathan Bedard
Comment 5 2019-09-18 07:41:41 PDT
Created attachment 379036 [details] Patch
Jonathan Bedard
Comment 6 2019-09-18 09:36:19 PDT
Created attachment 379044 [details] Patch
Aakash Jain
Comment 7 2019-09-19 13:51:46 PDT
Comment on attachment 379044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379044&action=review > Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:121 > + this.version_name = `${this.version_name}\u200B\u200B`; Is there another cleaner way we can implement this without adding these unicode characters? if not: a) please make these unicode characters a variable b) instead of hard-coding '-2', use len() of that variable c) worth adding a comment to explain why we are adding these unicode characters. > Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:212 > + const myMatch = this.sdk.match(SDK_REGEX); these variable names (myMatch, otherMatch) can be improved.
Jonathan Bedard
Comment 8 2019-09-19 14:31:15 PDT
Comment on attachment 379044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379044&action=review >> Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:121 >> + this.version_name = `${this.version_name}\u200B\u200B`; > > Is there another cleaner way we can implement this without adding these unicode characters? > > if not: > a) please make these unicode characters a variable > b) instead of hard-coding '-2', use len() of that variable > c) worth adding a comment to explain why we are adding these unicode characters. I was debating between this and just checking if the string end with ' E'....Upon further reflection, I think checking for the ' E' will be cleaner,
Jonathan Bedard
Comment 9 2019-09-19 14:58:55 PDT
Created attachment 379164 [details] Patch
Aakash Jain
Comment 10 2019-09-19 16:53:45 PDT
rs=me
Jonathan Bedard
Comment 11 2019-09-19 17:22:54 PDT
Created attachment 379177 [details] Patch for landing
WebKit Commit Bot
Comment 12 2019-09-19 17:46:17 PDT
Comment on attachment 379177 [details] Patch for landing Clearing flags on attachment: 379177 Committed r250113: <https://trac.webkit.org/changeset/250113>
WebKit Commit Bot
Comment 13 2019-09-19 17:46:18 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2019-09-19 17:47:21 PDT
<rdar://problem/55542444>
Jonathan Bedard
Comment 15 2019-09-23 12:26:52 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 16 2019-09-23 12:26:53 PDT
Created attachment 379384 [details] Patch
Aakash Jain
Comment 17 2019-09-23 12:38:31 PDT
rs=me
Jonathan Bedard
Comment 18 2019-09-23 13:12:34 PDT
Created attachment 379385 [details] Patch for landing
WebKit Commit Bot
Comment 19 2019-09-23 13:51:06 PDT
Comment on attachment 379385 [details] Patch for landing Clearing flags on attachment: 379385 Committed r250251: <https://trac.webkit.org/changeset/250251>
WebKit Commit Bot
Comment 20 2019-09-23 13:51:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.