Bug 201771

Summary: [WPE][GTK] BubblewrapLauncher leaks D-Bus proxy sockets
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, mcatanzaro, pgriffis
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 206533    
Attachments:
Description Flags
Patch
none
Patch mcatanzaro: review+

Michael Catanzaro
Reported 2019-09-13 14:06:44 PDT
I have a bunch of D-Bus proxy sockets leaked on the filesystem, created by the XDGDBusProxyLauncher class in BubblewrapLauncher.cpp. We shouldn't leak temporary files to disk; they should be removed when the web process quits. It's kinda hard to do if the xdg-dbus-proxy process itself isn't responsible for removing its socket. Why does WebKit have to create the socket file itself?
Attachments
Patch (3.01 KB, patch)
2022-02-10 04:32 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (3.01 KB, patch)
2022-02-10 05:56 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2022-02-10 04:28:55 PST
xdg-dbus-proxy removes the socket when the sync fd is closed by the application. In most of the cases the xdg-dbus-proxy process is killed before the sync fd is closed and the socket file is leaked. We should explicitly close the sync fd.
Carlos Garcia Campos
Comment 2 2022-02-10 04:32:36 PST
Created attachment 451518 [details] Patch This patch applyes on top of patch attached to bug #236437
Carlos Garcia Campos
Comment 3 2022-02-10 05:56:17 PST
Created attachment 451522 [details] Patch
Carlos Garcia Campos
Comment 4 2022-02-11 00:32:48 PST
Committed r289608 (247121@trunk): <https://commits.webkit.org/247121@trunk>
Note You need to log in before you can comment on or make changes to this bug.