Summary: | querySelectorAll id optimization no longer working | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Smith <catfish.man> | ||||||
Component: | DOM | Assignee: | David Smith <catfish.man> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
David Smith
2008-07-25 17:00:02 PDT
Created attachment 22488 [details] Patch; Passes run-webkit-tests and doesn't regress http://ejohn.org/apps/selectortest/#target Comment on attachment 22488 [details] Patch; Passes run-webkit-tests and doesn't regress http://ejohn.org/apps/selectortest/#target Looks good. Comment on attachment 22488 [details] Patch; Passes run-webkit-tests and doesn't regress http://ejohn.org/apps/selectortest/#target The check shouldn't be necessary, and can be made an ASSERT as far as I can tell. It should also read querySelector->m_attr== idAttr, not querySelector->m_attr.localName() == idAttr. I believe this will also break some uses of querySelector("#camalCase"); in quirks mode. We probably need to disable the optimization in quirks mode methinks. Created attachment 22511 [details]
patch
|