Bug 201752

Summary: Expose misspelling ranges for editable content to accessibility clients.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews212 for win-future
none
Patch
none
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2019-09-12 20:30:37 PDT
Expose misspelling ranges for editable content to accessibility clients.
Attachments
Patch (23.78 KB, patch)
2019-09-12 20:43 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews212 for win-future (14.36 MB, application/zip)
2019-09-12 21:53 PDT, EWS Watchlist 		no flags
Details
Patch (24.25 KB, patch)
2019-09-13 08:16 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (25.32 KB, patch)
2019-09-13 13:10 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (31.48 KB, patch)
2019-09-15 09:49 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (31.88 KB, patch)
2019-09-15 20:10 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2019-09-12 20:43:20 PDT
Created attachment 378708 [details] Patch
EWS Watchlist
Comment 2 2019-09-12 21:53:09 PDT
Comment on attachment 378708 [details] Patch Attachment 378708 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13028096 New failing tests: accessibility/misspelling-range.html css3/filters/blur-various-radii.html
EWS Watchlist
Comment 3 2019-09-12 21:53:11 PDT
Created attachment 378715 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
chris fleizach
Comment 4 2019-09-13 00:02:50 PDT
Comment on attachment 378708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378708&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:490 > + // So iterate forward or bakcwars depending on the desired search backwards > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2658 > +- (NSArray *)misspellingTextMarkerRange:(NSArray *)startTextMarkerRange direction:(NSString *)direction I feel like we should use a boolean for the direction rather than a string which is not well defined. easier to make a mistake with that kind of parameter. what do you think? > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4250 > + auto misspellingRange = m_object->getMisspellingRange(criteria.first, criteria.second); we can save a line here by doing if (auto misspellingRange = m_object->getMisspellingRange(criteria.first, criteria.second)) return [self textMarkerRangeFromRange:misspellingRange];
Andres Gonzalez
Comment 5 2019-09-13 08:16:24 PDT
Created attachment 378729 [details] Patch
Andres Gonzalez
Comment 6 2019-09-13 13:10:09 PDT
Created attachment 378750 [details] Patch
Andres Gonzalez
Comment 7 2019-09-13 13:15:16 PDT
Last upload adds fix for other platform builds.
Andres Gonzalez
Comment 8 2019-09-15 09:49:15 PDT
Created attachment 378816 [details] Patch
Andres Gonzalez
Comment 9 2019-09-15 09:50:55 PDT
Last upload fixes LayoutTest for WK1.
Andres Gonzalez
Comment 10 2019-09-15 20:10:57 PDT
Created attachment 378834 [details] Patch
chris fleizach
Comment 11 2019-09-16 00:19:13 PDT
Looks like we have WebKit1 layout test issues (DRT) +CONSOLE MESSAGE: line 41: TypeError: text.misspellingTextMarkerRange is not a function. (In 'text.misspellingTextMarkerRange(startRange, true)', 'text.misspellingTextMarkerRange' is undefined)
WebKit Commit Bot
Comment 12 2019-09-16 02:04:49 PDT
Comment on attachment 378834 [details] Patch Clearing flags on attachment: 378834 Committed r249893: <https://trac.webkit.org/changeset/249893>
WebKit Commit Bot
Comment 13 2019-09-16 02:04:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2019-09-16 02:05:23 PDT
<rdar://problem/55392178>
Note You need to log in before you can comment on or make changes to this bug.