| Summary: | Web Inspector: Tighter autocomplete bubbles | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Joseph Pecoraro
2019-09-12 15:28:46 PDT
Created attachment 378684 [details]
[PATCH] Proposed Fix
Created attachment 378685 [details]
[IMAGE] After
Comment on attachment 378684 [details] [PATCH] Proposed Fix r=me > Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:123 > + let intrinsicSize = this._completionLayoutElement.getBoundingClientRect(); We could use `realOffsetWidth`/`realOffsetHeight`, but I like the idea of only fetching `getBoundingClientRect` once. > Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:135 > + var width = Math.min(containerWidth, maximumWidth); `let` > Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:136 > + var paddedWidth = containerWidth; This isn't needed anymore. Comment on attachment 378684 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=378684&action=review >> Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:136 >> + var paddedWidth = containerWidth; > > This isn't needed anymore. Nice! |