RESOLVED FIXED 201742
Web Inspector: Tighter autocomplete bubbles 
https://bugs.webkit.org/show_bug.cgi?id=201742
Summary Web Inspector: Tighter autocomplete bubbles
Joseph Pecoraro
Reported 2019-09-12 15:28:46 PDT
Tighter autocomplete bubbles. Currently there is always ~22px of trailing space beyond the 10px padding.
Attachments
[PATCH] Proposed Fix (2.75 KB, patch)
2019-09-12 15:29 PDT, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
[IMAGE] After (44.07 KB, image/png)
2019-09-12 15:30 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-09-12 15:29:42 PDT
Created attachment 378684 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2019-09-12 15:30:28 PDT
Created attachment 378685 [details] [IMAGE] After
Devin Rousso
Comment 3 2019-09-12 15:46:13 PDT
Comment on attachment 378684 [details] [PATCH] Proposed Fix r=me > Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:123 > + let intrinsicSize = this._completionLayoutElement.getBoundingClientRect(); We could use `realOffsetWidth`/`realOffsetHeight`, but I like the idea of only fetching `getBoundingClientRect` once. > Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:135 > + var width = Math.min(containerWidth, maximumWidth); `let` > Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:136 > + var paddedWidth = containerWidth; This isn't needed anymore.
Joseph Pecoraro
Comment 4 2019-09-13 12:02:33 PDT
Comment on attachment 378684 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=378684&action=review >> Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:136 >> + var paddedWidth = containerWidth; > > This isn't needed anymore. Nice!
Joseph Pecoraro
Comment 5 2019-09-13 12:09:48 PDT
https://trac.webkit.org/changeset/249848/webkit
Radar WebKit Bug Importer
Comment 6 2019-09-13 12:10:19 PDT
<rdar://problem/55347967>
Radar WebKit Bug Importer
Comment 7 2019-09-13 12:10:21 PDT
<rdar://problem/55347970>
Note You need to log in before you can comment on or make changes to this bug.